huaxingao commented on code in PR #14984:
URL: https://github.com/apache/iceberg/pull/14984#discussion_r3624090183
##########
spark/v4.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -705,6 +701,9 @@ public void fullFunctionIdentifier() {
@TestTemplate
public void fullFunctionIdentifierNotRewrittenLoadFailure() {
+ assumeThat(catalogName)
+ .as("Spark 4.2 resolves spark_catalog.system functions in
SparkSessionCatalog")
+ .isNotEqualTo(SPARK_CATALOG);
Review Comment:
Using `assumeThat` here skips the `spark_catalog` / `SparkSessionCatalog`
case entirely rather than asserting anything. Since Spark 4.2 introduces new
behavior for exactly that case, could we add a positive assertion for it (view
loads and returns the expected result) instead of skipping? That keeps coverage
for the session-catalog path rather than silently excluding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
