Copilot commented on code in PR #838:
URL: https://github.com/apache/iceberg-cpp/pull/838#discussion_r3628010953
##########
src/iceberg/temp_linter_probe.cc:
##########
@@ -0,0 +1,16 @@
+// TEMP verification file — will be dropped before merge.
+// Intentionally violates .clang-tidy to confirm the new cpp-linter CLI runs.
Review Comment:
This file intentionally introduces clang-tidy/naming violations and will
cause the linter job to fail as long as it remains in the PR. If it’s only
meant as a temporary probe, it should be removed from the PR before merge (or
moved to a non-reviewed location / excluded from the linter) so main stays
green.
##########
.github/workflows/cpp-linter.yml:
##########
@@ -91,24 +91,36 @@ jobs:
with:
path: ${{ github.workspace }}/.sccache
key: sccache-cpp-linter-ubuntu-${{ github.run_id }}
- - uses:
cpp-linter/cpp-linter-action@0f6d1b8d7e38b584cbee606eb23d850c217d54f8 # v2.15.1
+ - uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 #
v6.3.0
+ if: github.event_name == 'pull_request'
+ - name: Install cpp-linter and clang tools
+ if: github.event_name == 'pull_request'
+ run: pip install "cpp-linter==1.13.0" "clang-format==22.1.8"
"clang-tidy==22.1.8"
Review Comment:
Consider pinning the Python version and invoking pip via the selected
interpreter. Without `python-version`, `setup-python` may change behavior over
time, and using bare `pip` can accidentally target a different interpreter than
the one set up by the action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
