rdblue commented on code in PR #17322:
URL: https://github.com/apache/iceberg/pull/17322#discussion_r3634627240
##########
core/src/main/java/org/apache/iceberg/FieldStats.java:
##########
@@ -46,10 +46,16 @@ interface FieldStats<T> {
/** The total value count, including null and NaN */
long valueCount();
- /** The total null value count */
Review Comment:
I think we also need a few more methods:
* `hasValueCount`: the value count may not be projected or may not have been
written
* `missingNullValueCount`, `missingNaNValueCount`: I think it is good to
have negations to make code easier to read, like `Map.nonEmpty`
* `hasAvgValueSizeInBytes`: this field may be null for the same reason as
the others, so we should treat it the same way (this was an oversight on my
part)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
