thswlsqls commented on code in PR #17250:
URL: https://github.com/apache/iceberg/pull/17250#discussion_r3635335969
##########
core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java:
##########
@@ -116,12 +116,12 @@ public static PlanTableScanRequest fromJson(JsonNode
json) {
}
boolean caseSensitive = true;
- if (json.has(CASE_SENSITIVE)) {
+ if (json.hasNonNull(CASE_SENSITIVE)) {
Review Comment:
@huaxingao Thanks — good call. Added a comment on `filter` (and on
`residual-filter` in `RESTFileScanTaskParser`) noting the throw on an explicit
null is intentional, to keep those fields aligned with the OpenAPI spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
