zhjwpku commented on code in PR #840:
URL: https://github.com/apache/iceberg-cpp/pull/840#discussion_r3635713204
##########
src/iceberg/transform.h:
##########
@@ -275,10 +275,11 @@ class ICEBERG_EXPORT TransformFunction {
return lhs.Equals(rhs);
}
- private:
- /// \brief Compare two partition specs for equality.
+ protected:
+ /// \brief Compare the common properties of two transform functions for
equality.
[[nodiscard]] virtual bool Equals(const TransformFunction& other) const;
Review Comment:
Nit: This is only used by the `==` overload, so maybe we can remove the
`[[nodiscard]]` attribute? Same for the below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
