LuciferYang commented on code in PR #2865:
URL: https://github.com/apache/iceberg-rust/pull/2865#discussion_r3636838497
##########
crates/iceberg/src/metadata_columns.rs:
##########
@@ -478,15 +484,26 @@ pub fn is_metadata_field(field_id: i32) -> bool {
)
}
-/// Checks if a column name is a metadata column.
+/// Checks if a column name is a metadata column of a data table.
Review Comment:
Confirmed against Java 1.11.0: all six return false. `row`/`pos`/`file_path`
are not in `META_COLUMNS`, and their ids (`MAX - 103`/`- 102`/`- 101`) are not
in `META_IDS`, so both `isMetadataColumn` overloads return false.
After 5f7f8dce the Rust side matches on both sides, covered in
`test_delete_file_columns_are_not_data_table_metadata_columns`:
`is_metadata_column_name` is false for all three names, and `is_metadata_field`
is false for `MAX - 101/-102`. `row` has no reserved id in this crate, so
`get_metadata_field_id("row")` is an error and `is_metadata_field(i32::MAX -
103)` is false too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
