badalprasadsingh commented on PR #1359: URL: https://github.com/apache/iceberg-go/pull/1359#issuecomment-5058484372
Hey @zeroshade & @laskoviymishka, thanks for your patience, and sorry for the delay. I've addressed all the review comments now. Whenever you have some time, I'd really appreciate another look. Also, while addressing the comments, I noticed: setting an _initial-default_ or _write-default_ on a column of type `timestamptz` (`TimestampTzType`) or `timestamptz_ns` (`TimestampTzNsType`) is always rejected, even for valid values. `UnionByNameWith` works same as `AddColumn` right now. Happy to address this issue for both of them separately in a new PR. Again, thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
