steveloughran commented on code in PR #17253:
URL: https://github.com/apache/iceberg/pull/17253#discussion_r3638311633
##########
core/src/main/java/org/apache/iceberg/DVUtil.java:
##########
@@ -49,11 +49,32 @@
class DVUtil {
private DVUtil() {}
+ /**
+ * Validate a DV. Based on the original from BaseDeleteLoader.
+ *
+ * @param dv deletion vector.
+ */
+ private static void validateDV(DeleteFile dv) {
Review Comment:
I wasn't sure about this, as I know that making changes to other bits of
code don't always go down well, but here I will. I will also improve the error
message when the content length is > 2GB to include the full dvdesc() info,
(filename, offset, length) rather than just the requested length. Whoever reads
the error logs will appreciate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
