C-Loftus commented on PR #1426: URL: https://github.com/apache/iceberg-go/pull/1426#issuecomment-5059349132
Thanks very much for your review and that context @zeroshade that makes sense to me and I agree with that approach! I have reset this branch to have a clean diff to review in my latest commit https://github.com/apache/iceberg-go/pull/1426/commits/6ec8f7ad3357a5e08bbbcb25635b84d017bfd8c1 and then addressed your feedback. Let me know if you have any thoughts with this new approach: - Reworked projjson CRS handling to pass table properties explicitly through Arrow conversion options instead of context.Context. - Added public option-based APIs for schema/type conversion while keeping existing APIs as wrappers. - Write paths now resolve projjson:<property> from table properties and embed the projjson document into GeoArrow metadata. - Table-aware read paths now recover the original projjson:<property> CRS by matching field ID to the table schema and validating the embedded projjson matches the table property. - Added these the new options through scan, write, rewrite, position/equality delete, and projection paths. I have added tests for write metadata, round trip write/read CRS recovery, mismatch errors, missing field ID errors, and unresolved property errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
