terrytlu commented on PR #17317: URL: https://github.com/apache/iceberg/pull/17317#issuecomment-5059480672
> > **3. New config** — `list-iceberg-tables-legacy` is just a defensive fallback. The old path has run stably in production for a long time, so the flag lets users revert if the new server-side-filter path hits an unexpected issue. It's off by default. > > Do we expect any issues with the new strategy? Seems like a quite nice optimisation, without any obvious user facing drawback. Also we prefer as few configs as possible. @pvary I don't expect any issue with the new strategy for listTables: get_table_names_by_filter is a long-standing HMS API and the params filter works reliably for tables. The only caveat (unreliable table_type filtering for VIRTUAL_VIEW on Hive 2.3.x) affects listViews only, which keeps the client-side resolution anyway. I've drop the list-iceberg-tables-legacy config and always use the server-side filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
