u70b3 commented on issue #441:
URL: https://github.com/apache/iceberg-cpp/issues/441#issuecomment-5065749236

   Hi, I’d like to contribute a focused correctness follow-up to the existing 
position delete writer. `PositionDeleteWriter::Write(ArrowArray*)` currently 
forwards batch data without collecting referenced data-file paths, so its 
metadata differs from `WriteDelete()`: a single-path batch misses 
`referenced_data_file`, while a multi-path batch may retain file-path/position 
bounds that should be removed. I plan to limit the change to extracting owned 
paths before the underlying write, committing them only after a successful 
write, and adding focused unit tests. No public API, rolling/fanout writer, or 
sort-order changes are included.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to