wombatu-kun commented on PR #16543: URL: https://github.com/apache/iceberg/pull/16543#issuecomment-5066967180
Done 050b00e2c. Same commit adds the Apache DataSketches Memory attribution to the Spark and Flink runtime NOTICE files, since its Yahoo Inc. / Verizon Media copyrights have to live in the aggregated NOTICE once the dependency copies are excluded. Two pre-existing gaps, not addressed here: - The shaded jars carry two root `LICENSE` and two root `NOTICE` entries: the repo-root pair `deploy.gradle` injects into every module jar (shadow merges it back in from `iceberg-core` et al.) plus the bundle's own aggregated pair. Only the latter has the third-party attributions, and neither `exclude` nor `duplicatesStrategy` can dedup it - it needs a Transformer. - `iceberg-bundled-guava` still has the `META-INF/LICENSE` duplication; same 4-line fix. Can fold either in here or file separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
