xanderbailey opened a new pull request, #2887: URL: https://github.com/apache/iceberg-rust/pull/2887
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> `ParquetWriterBuilder::from_table_properties` previously only translated the content-defined-chunking settings; every other Parquet knob silently fell through to parquet-rs (arrow-rs) defaults, which diverge from the Java implementation. This PR maps the row-group / page / dictionary sizing and compression table properties into the parquet-rs `WriterProperties`: - `write.parquet.compression-codec` (default `zstd`) and `write.parquet.compression-level` - `write.parquet.row-group-size-bytes` (default 128 MB) - `write.parquet.page-size-bytes` (default 1 MB) - `write.parquet.page-row-limit` (default 20000) - `write.parquet.dict-size-bytes` (default 2 MB) How the new Iceberg defaults differ from the parquet-rs defaults that were previously in effect: - compression: parquet-rs defaults to UNCOMPRESSED, so files were previously written uncompressed; the Java default is zstd. - row group size: parquet-rs sets no byte limit and flushes row groups by row count only (~1M rows); we now apply a 128 MB byte budget. The row-count limit is left at the parquet-rs default since Iceberg has no property for it, so row groups now flush at 128 MB or ~1M rows, whichever comes first. - dictionary page size: parquet-rs defaults to 1 MB; the Iceberg default is 2 MB. - page size (1 MB) and page row limit (20000) already matched parquet-rs, so those are unchanged in practice. ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
