pvary commented on code in PR #17337:
URL: https://github.com/apache/iceberg/pull/17337#discussion_r3645604833
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java:
##########
@@ -478,4 +480,118 @@ public void roundTripSerdeWithCredentials() {
assertThat(LoadTableResponseParser.toJson(LoadTableResponseParser.fromJson(json),
true))
.isEqualTo(expectedJson);
}
+
+ @Test
+ public void roundTripSerdeWithLabels() {
+ String uuid = "386b9f01-002b-4d8c-b77f-42c3fd3b7c9b";
+ TableMetadata metadata =
+ TableMetadata.buildFromEmpty()
+ .assignUUID(uuid)
+ .setLocation("location")
+ .setCurrentSchema(
+ new Schema(Types.NestedField.required(1, "x",
Types.LongType.get())), 1)
+ .addPartitionSpec(PartitionSpec.unpartitioned())
+ .addSortOrder(SortOrder.unsorted())
+ .discardChanges()
+ .withMetadataLocation("metadata-location")
+ .build();
+
+ LoadTableResponse response =
+ LoadTableResponse.builder()
+ .withTableMetadata(metadata)
+ .withLabels(
+ ImmutableLabels.builder()
+ .object(ImmutableMap.of("owner", "team-a"))
+ .addFields(
+ ImmutableFieldLabels.builder()
+ .fieldId(1)
+ .labels(ImmutableMap.of("classification", "pii"))
+ .build())
+ .build())
+ .build();
+
+ String expectedJson =
+ String.format(
+ "{\n"
Review Comment:
Use text blocks for long json constants here too.
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadViewResponseParser.java:
##########
@@ -245,4 +247,117 @@ public void roundTripSerdeWithConfig() {
assertThat(LoadViewResponseParser.toJson(LoadViewResponseParser.fromJson(json),
true))
.isEqualTo(expectedJson);
}
+
+ @Test
+ public void roundTripSerdeWithLabels() {
+ String uuid = "386b9f01-002b-4d8c-b77f-42c3fd3b7c9b";
+ ViewMetadata viewMetadata =
+ ViewMetadata.builder()
+ .assignUUID(uuid)
+ .setLocation("location")
+ .addSchema(new Schema(Types.NestedField.required(1, "x",
Types.LongType.get())))
+ .addVersion(
+ ImmutableViewVersion.builder()
+ .schemaId(0)
+ .versionId(1)
+ .timestampMillis(23L)
+ .defaultNamespace(Namespace.of("ns1"))
+ .build())
+ .setCurrentVersionId(1)
+ .build();
+
+ LoadViewResponse response =
+ ImmutableLoadViewResponse.builder()
+ .metadata(viewMetadata)
+ .metadataLocation("custom-location")
+ .labels(
+ ImmutableLabels.builder()
+ .object(ImmutableMap.of("owner", "team-a"))
+ .addFields(
+ ImmutableFieldLabels.builder()
+ .fieldId(1)
+ .labels(ImmutableMap.of("classification", "pii"))
+ .build())
+ .build())
+ .build();
+
+ String expectedJson =
+ "{\n"
Review Comment:
Use text blocks for long json constants here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
