zeroshade commented on code in PR #1355:
URL: https://github.com/apache/iceberg-go/pull/1355#discussion_r3647331713
##########
manifest.go:
##########
@@ -2324,6 +2384,7 @@ func NewDataFileBuilder(
recordCount int64,
fileSize int64,
) (*DataFileBuilder, error) {
+ _ = fieldIDToFixedSize
Review Comment:
Non-blocking: `NewDataFileBuilder` still retains and ignores
`fieldIDToFixedSize` (`_ = fieldIDToFixedSize`). Consider dropping the dead
parameter now that the write path derives width from the manifest schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
