tanmayrauth commented on PR #1501:
URL: https://github.com/apache/iceberg-go/pull/1501#issuecomment-5073495926
@zeroshade Thanks for the review, addressed all three in the latest commit:
delete-file result metrics now follow Java's ScanMetricsUtil.fileTask per-task
accumulation (a delete applying to N tasks counts N times, no cross-path dedup)
so the Java-parity field names stay directly comparable, while DV sizing keeps
using per-blob content_size_in_bytes; the emitted ScanReport.Filter is now run
through a new iceberg.SanitizeExpression before serialization so predicate
literals are masked (structure, column refs, and ops preserved, IN/NOT IN
keep their arity) and never leak to reporters/REST sinks — it masks values
rather than replicating Java's typed placeholders, which I noted in the doc
comment; and projectedFields now resolves the actual projected schema and
maps every id (including nested) to its full dotted name via
Schema.FindColumnName, matching TypeUtil.getProjectedIds + findColumnName, with
new tests
covering nested schemas, filter redaction, and the per-task delete counts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
