nssalian commented on code in PR #17256:
URL: https://github.com/apache/iceberg/pull/17256#discussion_r3649477268
##########
open-api/rest-catalog-open-api.py:
##########
@@ -122,6 +122,10 @@ class PrimitiveType(RootModel[str]):
root: str = Field(..., examples=[['long', 'string', 'fixed[16]',
'decimal(10,2)']])
+class VariantType(RootModel[Literal['variant']]):
Review Comment:
I ran `make generate` original but the output looked off only because the
schema sat down near `MapType`. Moved it next to `PrimitiveType` per your
suggestion, so placement is now stable.
##########
open-api/rest-catalog-open-api.py:
##########
@@ -122,6 +122,10 @@ class PrimitiveType(RootModel[str]):
root: str = Field(..., examples=[['long', 'string', 'fixed[16]',
'decimal(10,2)']])
+class VariantType(RootModel[Literal['variant']]):
Review Comment:
I ran `make generate` originally but the output looked off only because the
schema sat down near `MapType`. Moved it next to `PrimitiveType` per your
suggestion, so placement is now stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
