TwinklerG commented on PR #2765: URL: https://github.com/apache/iceberg-rust/pull/2765#issuecomment-5077285852
> This LGTM after revision. Thanks for addressing the feedback, @viirya! I agree with @advancedxy that it might be nice to get #2665 in first, but its diff is over 10x the number of lines, has no reviews at the moment, and merge conflicts. I will take a review pass on #2665, but IMO it doesn't make sense to block this PR on #2665 at this point. #2665 can be adjusted to adopt the feedback we presented here. Thanks @mbutrovich ! I am the author of #2665 . I agree with you. I do not think it is suitable to merge it soon as it is ready for production, although I think it deserves a review. Currently I am still working with @advancedxy on #2665 to make the APIs and inner implementation better. It is not stable now, but its idea remains the same——expand `Term` to enum and add support for Transform Bound Predicate such as `bucket(10, "id") = 5`, `year(ts) = 54`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
