rdblue commented on a change in pull request #1823: URL: https://github.com/apache/iceberg/pull/1823#discussion_r550694362
########## File path: aws/src/main/java/org/apache/iceberg/aws/glue/LockManager.java ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws.glue; + +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * An interface for locking, used to ensure Glue catalog commit isolation. + */ +interface LockManager extends AutoCloseable { + + /** + * Try to acquire a lock + * @param lockId lock ID + * @throws LockNotAcquiredException if lock is not acquired + */ + void acquire(LockId lockId); + + /** + * Release a lock + * @param lockId lock ID + * @throws IllegalArgumentException if lock entity not found or trying to unlock with a wrong owner ID + */ + void release(LockId lockId); + + /** + * Initialize lock manager from catalog properties. + * @param properties catalog properties + */ + void initialize(Map<String, String> properties); + + class LockId { + + private final String entityId; + private final String ownerId; + + LockId(String entityId, String ownerId) { Review comment: Why does this include owner ID? If it identifies a lock, that shouldn't depend on owner. And if this identifies a lock, what is the entity ID? It seems like you want the lock manager to have an ID (owner ID) and a lock to have an ID (entity ID), but this mixes them together. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
