plusplusjiajia commented on PR #828:
URL: https://github.com/apache/iceberg-cpp/pull/828#issuecomment-5078181212
> Could we add an end-to-end test using the actual Arrow FileIO
implementations? The current tests use mocks and don’t cover the full `REST →
ResolvingFileIO → FileIORegistry → Arrow FileIO` path.
@MisterRaindrop Done in `test/rest_arrow_file_io_test.cc` — full REST ->
ResolvingFileIO -> registry -> Arrow FileIO chain against the real
implementations: a local round-trip with real bytes, plus an S3 case asserting
a vended `oss://` credential is applied. Good suggestion — the mocks couldn't
catch either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
