fallintoplace opened a new pull request, #843: URL: https://github.com/apache/iceberg-cpp/pull/843
Commit property validation currently accepts a valid integer prefix and ignores trailing characters. For example, `commit.retry.num-retries=4x` is parsed as `4`, even though the equivalent Java validation rejects the value. This change requires `std::from_chars` to consume the complete property value while preserving the existing invalid-argument and out-of-range errors. Regression coverage includes alphanumeric and decimal suffixes. Tested with: - `ctest --test-dir build -R ^table_test$ --output-on-failure` - full CTest suite (17 test binaries) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
