uros-b opened a new pull request, #17380: URL: https://github.com/apache/iceberg/pull/17380
Simplifies the two `instanceof`-followed-by-cast blocks in `BigQueryMetastoreClientImpl` to use pattern-matching `instanceof`, as flagged by the Error Prone `[PatternMatchingInstanceof]` check. - `beforeEval(...)`: `((BaseServiceException) exception).isRetryable()` - binds `serviceException` in the `instanceof` and calls it directly. - `handleBigQueryRetryException(...)`: `throw (RuntimeException) cause;` - binds `runtimeException` in the `instanceof` and rethrows it. These are the only two occurrences in the file. Pure readability cleanup, no behavior change. Also, note that Java 17 (the project's release level) supports the syntax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
