moomindani commented on PR #16574: URL: https://github.com/apache/iceberg/pull/16574#issuecomment-5086057363
Still active and waiting for review — not stale. Status since the last update: - All 56 CI checks are green, and the branch is mergeable with no unresolved review threads. - @gaborkaszab's REST catalog finding from May 27 is addressed: `RESTSessionCatalog.metricsReporter(...)` now wraps the per-table `RESTMetricsReporter` in `FilteringMetricsReporter` as well, so the filter applies uniformly to the user-supplied reporter and the catalog-injected one. The PR description documents the three wiring options considered (A/B/C) and why A was chosen — happy to switch if a different shape is preferred. - No behavior change on the default path: when neither `metrics-reporter.table-name.include` nor `.exclude` is set, the resolved reporter is returned unwrapped. @gaborkaszab would you mind taking another look at the REST fix, since you raised the original issue? @ebyhr @jbonofre — a review from any of you would also be welcome. This is a small, self-contained change on top of #16573. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
