moomindani commented on PR #3623: URL: https://github.com/apache/iceberg-python/pull/3623#issuecomment-5086484079
Note on the red CI: the `integration-test` failure here is expected and not a defect in this PR. ``` FAILED tests/integration/test_reads.py::test_upgrade_table_version[session_catalog_hive] E NotImplementedError: Writing V3 is not yet supported, see: https://github.com/apache/iceberg-python/issues/1551 pyiceberg/table/metadata.py:581 ==== 1 failed, 486 passed, 70 skipped ==== ``` Upgrading to v3 produces a `TableMetadataV3`, and persisting it goes through `TableMetadata.model_dump_json()`, which still raises `NotImplementedError` until V3 metadata serialization lands in #3551. Everything else in the suite passes, and the unit test for the upgrade itself (`test_update_metadata_upgrade_to_v3`) is green. So this stays a draft until #3551 merges, at which point I'll rebase and mark it ready for review. @rambleraptor — no rush, just flagging that this one is queued behind #3551. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
