arpitjain099 commented on PR #2867: URL: https://github.com/apache/iceberg-rust/pull/2867#issuecomment-5088188637
Thanks for the thorough review, and for actually reproducing both overflows rather than taking my word for it. On the ordering point, that was deliberate: a file shorter than `MIN_FILE_LENGTH` can't hold valid magic anyway, so "too short" is the accurate diagnosis, and checking length first is what avoids reading out of range to discover the magic is bad. Happy to flip it if you'd rather short-but-garbage files keep reporting "bad magic", but I think the current order gives the more useful error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
