rambleraptor commented on code in PR #1477:
URL: https://github.com/apache/iceberg-go/pull/1477#discussion_r3659740844
##########
catalog/rest/vended_creds.go:
##########
@@ -108,14 +114,20 @@ func (v *vendedCredentialRefresher) loadFS(ctx
context.Context) (iceio.IO, error
}
defer v.mu.Release(1)
- if v.cachedIO != nil && !v.now().After(v.expiresAt) {
+ if v.cachedIO != nil && !v.expired() {
return v.cachedIO, nil
}
var config iceberg.Properties
- if v.cachedIO == nil {
+ switch {
+ case v.cachedIO == nil:
config = v.props
Review Comment:
Thanks for the nit @zeroshade. I was OOO last week and just getting around
to it. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
