fallintoplace commented on code in PR #1489:
URL: https://github.com/apache/iceberg-go/pull/1489#discussion_r3659958833
##########
catalog/catalog.go:
##########
@@ -135,7 +135,8 @@ type Catalog interface {
// RenameTable tells the catalog to rename a given table by the
identifiers
// provided, and then loads and returns the destination table
RenameTable(ctx context.Context, from, to table.Identifier)
(*table.Table, error)
- // CheckTableExists returns if the table exists
+ // CheckTableExists reports whether the identifier is registered as a
table in
+ // the catalog. It does not validate that the table metadata file is
readable.
Review Comment:
Thanks, these all make sense. I’ve applied them in c8c0977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
