rambleraptor commented on code in PR #83:
URL:
https://github.com/apache/terraform-provider-iceberg/pull/83#discussion_r3660439866
##########
build.sh:
##########
@@ -18,7 +18,8 @@
# --- Configuration ---
PROVIDER_NAMESPACE="apache"
PROVIDER_TYPE="iceberg"
-VERSION="1.0.0"
+# Local dev build, not a release. Override with VERSION=0.1.0 ./build.sh
+VERSION="${VERSION:-0.0.0}"
Review Comment:
I don't think so.
The only places that need the version are in the release pipeline.
GoReleaser fetches the version from the tag, and the GitHub actions work takes
it from git tags (if it's necessary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
