zeroshade commented on PR #1563: URL: https://github.com/apache/iceberg-go/pull/1563#issuecomment-5096640436
Approved — but #1522 merged just ahead of this and also rewrote schemasToGlueColumns (it adds field-ID-keyed comment back-fill). Could you rebase on main, @badalprasadsingh, and confirm the comment back-fill still holds under the new name-keyed ordering? The two overlap in that one function, so they should be reconciled together. Happy to merge once rebased and green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
