moomindani commented on PR #16250: URL: https://github.com/apache/iceberg/pull/16250#issuecomment-5100313249
Rebased onto the latest `main` to resolve the merge conflict in `gradle/libs.versions.toml`. The conflict was purely mechanical — Dependabot bumps landed in the same region of the version catalog, so `orc` moved to `1.9.9` on `main` while this branch still carried `1.9.8` alongside the new `opentelemetry` entry. Took `main`'s version and kept the `opentelemetry` entry in place. No changes to the reporter itself. All 39 CI checks are green. Verified locally as well: - The PR diff is identical to before the rebase (7 files, +1490), and the 9 commits are preserved rather than squashed, so the review history stays navigable. - `:iceberg-core:compileJava` / `compileTestJava`, `spotlessCheck`, `checkstyleMain` and `checkstyleTest` all pass. - `TestOtelMetricsReporter`: 12/12 green. - `opentelemetry` does not appear on `:iceberg-core:runtimeClasspath` — still `compileOnly` for the API with the SDK confined to tests, which is the arrangement agreed on the dev@ thread. @nastra thanks again for the reviews — all of your comments are addressed and the threads are resolved on my side, so this should be ready for another look whenever you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
