blackmwk commented on code in PR #2918:
URL: https://github.com/apache/iceberg-rust/pull/2918#discussion_r3664635652
##########
crates/iceberg/src/test_utils.rs:
##########
Review Comment:
+1
##########
crates/iceberg/src/catalog/utils.rs:
##########
@@ -120,3 +122,93 @@ async fn delete_data_files(io: &FileIO, manifest_paths:
&HashSet<String>) -> Res
})
.await
}
+
+#[cfg(test)]
+mod tests {
Review Comment:
I'm worrying about the maintainability. I prefer to create an issue to add
the integration tests later.
##########
crates/iceberg/src/catalog/utils.rs:
##########
@@ -120,3 +122,93 @@ async fn delete_data_files(io: &FileIO, manifest_paths:
&HashSet<String>) -> Res
})
.await
}
+
+#[cfg(test)]
+mod tests {
Review Comment:
This is a utilit method shared by all catalogs, so I don't want to add ut
for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
