fallintoplace opened a new pull request, #1581: URL: https://github.com/apache/iceberg-go/pull/1581
## What changed Canonicalize partition values used internally for fanout and clustered-writer lookup. Binary and fixed values use a distinct string-backed key, and float NaNs use stable typed sentinels. Original partition values remain unchanged for paths and metadata. Byte values are cloned when a partition is first recorded so metadata does not retain Arrow-owned storage. Fixed-size Arrow binary values are also converted to Iceberg literals before grouping. ## Why Binary and fixed partition values are byte slices, which panic when used as Go map keys. Clustered partition equality could panic for the same reason, while repeated NaNs did not compare equal and could split one logical partition. ## Testing Coverage exercises binary, fixed, and NaN grouping; source-buffer mutation; clustered equality; and closed-partition tracking. - `go test ./table` - `go vet ./table` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
