varun-lakhyani commented on code in PR #17284:
URL: https://github.com/apache/iceberg/pull/17284#discussion_r3669420461
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -578,9 +579,31 @@ private static InputFile newInputFile(FileIO io,
ManifestFile manifest) {
return contentCache(io).tryCache(input);
}
+ if (eagerFetchEnabled(io)) {
Review Comment:
Added in TestManifestReader - 2 tests
- verifies it routes to EagerInputFile based on flag and size threshold
(required making newInputFile package-private)
- verifies manifest entries are read back correctly when eager fetch is
enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
