DerGut commented on code in PR #2890:
URL: https://github.com/apache/iceberg-rust/pull/2890#discussion_r3669491151
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -1134,24 +1134,57 @@ pub(crate) mod tests {
}
#[tokio::test]
- async fn
test_dropping_a_namespace_also_drops_namespaces_nested_under_that_one() {
+ async fn test_drop_namespace_throws_error_if_namespace_has_children() {
Review Comment:
nit: Rust doesn't really have a concept of throwing
```suggestion
async fn test_drop_namespace_returns_error_if_namespace_has_children() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
