dramaticlly commented on code in PR #17399: URL: https://github.com/apache/iceberg/pull/17399#discussion_r3669785059
########## api/src/main/java/org/apache/iceberg/actions/RepairManifests.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.ManifestFile; + +/** + * An action that repairs incorrect statistics in the manifests of a table. + * + * <p>Implementations rewrite the manifests of the table, producing a new set of manifests in which + * the statistics of the entries are corrected to match the underlying data and delete files. + */ +public interface RepairManifests extends SnapshotUpdate<RepairManifests, RepairManifests.Result> { + + /** + * Repairs incorrect statistics of manifest entries, such as record counts, file sizes and column + * level statistics. + * + * @return this for method chaining + */ + RepairManifests repairEntryStats(); + + /** + * Determines the repairs that would be performed without actually committing the operation to the + * table. + * + * @return this for method chaining + */ + RepairManifests dryRun(); Review Comment: agree that we don't have a catch-all consumer for both incorrect manifest-list or manifest entry, but I still think it would be beneficial to at least know which files are examined with during dry-run. I think it might help the replication to be more resilient if we run this action on both source and target and ensure the result file set are the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
