smaheshwar-pltr commented on code in PR #17404:
URL: https://github.com/apache/iceberg/pull/17404#discussion_r3670118795
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -126,44 +125,59 @@ protected String tableName() {
@Override
public FileIO io() {
+ // Avoid current() (which may refresh) on the unencrypted fast path.
+ return tableKeyId == null ? fileIO : io(current());
Review Comment:
u sure it's fine to call current() in io / encryption? just feels like
design smell here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
