smaheshwar-pltr commented on code in PR #17404:
URL: https://github.com/apache/iceberg/pull/17404#discussion_r3670152179


##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -36,6 +37,12 @@
 import org.apache.iceberg.util.ByteBuffers;
 import org.apache.iceberg.util.SerializableMap;
 
+/**
+ * An immutable {@link EncryptionManager} for standard (envelope) encryption 
whose keys are sourced
+ * from table metadata. Minting a manifest-list key is a pure operation ({@link
+ * #mintManifestListKey}) that returns the new key(s) for the caller to 
persist into metadata rather
+ * than storing them, so instances are safe to share across concurrent commits 
and to serialize.
+ */

Review Comment:
   slop



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to