moomindani commented on PR #2804: URL: https://github.com/apache/iceberg-rust/pull/2804#issuecomment-5111788534
Gentle ping — open for ~2.5 weeks, CI green, no review yet. Per the spec, writers must use a column's `write-default` for columns they don't supply. DataFusion's insert planner consults `TableProvider::get_column_default` for columns omitted from an `INSERT` and falls back to `NULL` when it's not implemented — which `IcebergTableProvider` doesn't, so omitted columns silently get NULL instead of the declared write-default. Two files. @CTTY you've reviewed most of the recent `datafusion` integration work — would you mind taking a look? Closes #2803, part of #2411. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
