wgtmac commented on code in PR #16836:
URL: https://github.com/apache/iceberg/pull/16836#discussion_r3675847305
##########
format/expressions-spec.md:
##########
@@ -235,7 +235,7 @@ Note that `year`, `month`, and `hour` transforms produce
ordinal values and not
| Parameterized function name | Description
| Source types
| Result type |
|-----------------------------|-----------------------------------------------------------------------|----------------------------------------------------------------------------------------------|-------------|
-| `bucket(N, value)` | Hash of value, mod `N` (see [table spec
details][bucket-ref]) | Any primitive except for `geometry`,
`geography`, `variant`, `boolean`, `float`, or `double` | `int` |
+| `bucket(N, value)` | Hash of value, mod `N` (see [table spec
details][bucket-ref]) | Any primitive except for `geometry`,
`geography`, `boolean`, `float`, `double`, or `variant` | `int` |
Review Comment:
```suggestion
| `bucket(N, value)` | Hash of value, mod `N` (see [table spec
details][bucket-ref]) | Any primitive except for `geometry`,
`geography`, `boolean`, `float`, or `double` | `int` |
```
##########
format/expressions-spec.md:
##########
@@ -223,7 +223,7 @@ All partition transforms produce `null` for a `null` input
value.
| Function name | Description
| Source types |
Result type |
|-------------------|--------------------------------------------------------------|----------------------------------------------------------------------|-------------|
-| `identity(value)` | Source value, unmodified
| Any primitive except for `geometry`, `geography`, and `variant` |
Source type |
+| `identity(value)` | Source value, unmodified
| Any primitive except for `geometry` and `geography`. Nested types
(`struct`, `list`, and `map`) and `variant` are not supported. | Source type |
Review Comment:
```suggestion
| `identity(value)` | Source value, unmodified
| Any primitive except for `geometry` and `geography` | Source type |
```
##########
format/spec.md:
##########
@@ -567,7 +567,7 @@ Partition field IDs must be reused if an existing partition
spec contains an equ
| Transform name | Description
| Source types
| Result type |
|-------------------|--------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------|-------------|
-| **`identity`** | Source value, unmodified
| Any except for `geometry`, `geography`, and `variant`
| Source type |
+| **`identity`** | Source value, unmodified
| Any primitive except for `geometry` and `geography`. Nested types
(`struct`, `list`, and `map`) and `variant` are not supported. | Source type |
Review Comment:
```suggestion
| **`identity`** | Source value, unmodified
| Any primitive except for `geometry` and `geography` | Source type |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
