dramaticlly commented on code in PR #17412: URL: https://github.com/apache/iceberg/pull/17412#discussion_r3677269688
########## api/src/test/java/org/apache/iceberg/expressions/TestInclusiveMetricsEvaluator.java: ########## Review Comment: nit, not related to the change but I think the reason to prune the field 104 and 105 for `notNull` predicate is a bit different from "optional_address is optional". Since both are nested within an optional struct, we cannot decide based on schema whether values are nullable or not. The decision is made based on the leaf field metrics (value count = 5 and null count = 5. so all values are null and evaluate to false) Meant to comment on LINE966, my bad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
