roberto-trani commented on code in PR #2683:
URL: https://github.com/apache/iceberg-rust/pull/2683#discussion_r3678577523
##########
crates/iceberg/src/spec/manifest_list/manifest_file.rs:
##########
@@ -179,6 +179,18 @@ impl ManifestFile {
///
/// This method will also initialize inherited values of
[`ManifestEntry`](crate::spec::ManifestEntry), such as `sequence_number`.
pub async fn load_manifest(&self, file_io: &FileIO) -> Result<Manifest> {
+ self.load_manifest_with(file_io, None).await
Review Comment:
This `None` default is what the write path still hits: `SnapshotProducer`
loads existing manifests through plain `load_manifest()`
(`transaction/snapshot.rs`), so a `fast_append` commit to a table with a DuckDB
written delete manifest still fails with the `SchemaEnum` parse error.
Verified on this branch against a real S3 Tables table: reads are fixed but
commits still break.
Could the transaction path be plumbed through `load_manifest_with` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
