RussellSpitzer commented on PR #17424:
URL: https://github.com/apache/iceberg/pull/17424#issuecomment-5125425077
Overall I think this is good. I have some style/function comments on the
code itself. I really think we should drop all the state we currently have
since I think at the end of the day the only state we need is
"Have we decided to shred or not?"
"What is that shredded type?"
Currently we have a widest decimal, widest integer, cached , and set
I wrote this inline but in my head this could be
Are we trying to shred to a type and haven't picked one? Set it
Is the current type not in the family of the set type? We can't shred
Is the current type in the family of the set type?
is it narrower or equal? do nothing
is it wider? Set it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
