thswlsqls commented on code in PR #17276:
URL: https://github.com/apache/iceberg/pull/17276#discussion_r3680321480
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestHashKeyGenerator.java:
##########
@@ -164,6 +164,48 @@ void testEqualityKeys() throws Exception {
assertThat(getSubTaskId(writeKey3, writeParallelism,
maxWriteParallelism)).isEqualTo(0);
}
+ @Test
+ void rangeModeWithEqualityFields() throws Exception {
Review Comment:
@mxm Thanks for the review — you're right that the name should match the
rest of the file. This case has equality fields set, so it takes the
`equalityFieldKeySelector` branch rather than falling back to none; I renamed
it `testRangeModeWithEqualityFields` and added
`testRangeModeFallsBackToDistributionModeNone` for the branch you pointed at
below, mirroring `testHashModeWithoutEqualityFieldsFallsBackToNone`. Happy to
rename either one if you'd prefer different wording.
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/HashKeyGenerator.java:
##########
Review Comment:
@mxm Thanks — added `testRangeModeFallsBackToDistributionModeNone`, which
covers this branch the same way
`testHashModeWithoutEqualityFieldsFallsBackToNone` does for hash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
