szlta commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r3683489300
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3665,6 +3676,43 @@ components:
additionalProperties:
type: string
+ KeyManagementCredential:
+ type: object
+ description: |
+ Provider-specific credential config for accessing one or more KMS keys
required by an encrypted
+ table operation.
+
+ The key-management provider is advertised in catalog configuration,
such as `encryption.kms-type`
+ returned from `/v1/config`. The `config` map contains
provider-specific properties for the
+ selected key-management provider.
+
+ Catalogs that return `key-management-credentials` for an operation
must include credentials for all
+ KMS key IDs required by table encryption metadata. Clients should
select the credential config by
+ matching KMS key identifiers referenced by table encryption metadata,
such as
+ `EncryptedKey.encrypted-by-id`, against `kms-key-ids`.
+
+ Credential configs should use provider-specific expiration mechanisms
where available and should
+ be scoped to the minimum required KMS operations and listed KMS key
IDs where the provider
+ supports it. Clients must not persist credentials beyond any
provider-specific expiration.
+ required:
+ - kms-key-ids
+ - config
+ properties:
+ kms-key-ids:
+ type: array
+ description: |
+ KMS key identifiers for which the credential config is relevant.
+
+ Clients should match these values against KMS key identifiers
referenced by table encryption
+ metadata, such as `EncryptedKey.encrypted-by-id`.
+ items:
+ type: string
+ config:
+ type: object
+ description: Provider-specific credential configuration for
accessing the listed KMS key IDs.
+ additionalProperties:
+ type: string
Review Comment:
Probably, but in the scope of this change. I'd leave this consistent with
`StorageCredential` i.e. without standardization for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
