hsiang-c commented on code in PR #2875:
URL: https://github.com/apache/iceberg-rust/pull/2875#discussion_r3685816473
##########
crates/iceberg/src/spec/partition.rs:
##########
@@ -168,10 +168,14 @@ impl PartitionSpec {
let value = data[i].as_ref();
format!(
"{}={}",
- field.name,
- field
- .transform
- .to_human_string(&field_types[i].field_type, value)
+ urlencoding::encode(field.name.as_str()).into_owned(),
Review Comment:
@CTTY Good catch +1 that we should be consistent with Iceberg Java.
##########
crates/iceberg/src/spec/partition.rs:
##########
@@ -168,10 +168,14 @@ impl PartitionSpec {
let value = data[i].as_ref();
format!(
"{}={}",
- field.name,
- field
- .transform
- .to_human_string(&field_types[i].field_type, value)
+ urlencoding::encode(field.name.as_str()).into_owned(),
Review Comment:
@CTTY Good catch and +1 that we should be consistent with Iceberg Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
