szehon-ho commented on code in PR #17256:
URL: https://github.com/apache/iceberg/pull/17256#discussion_r3686592612
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2509,7 +2515,10 @@ components:
type: boolean
Type:
+ # VariantType must stay before PrimitiveType - codegen drops the `not:`,
so
+ # order decides resolution. Do not alphabetize.
Review Comment:
Yea this is definitely fragile. i was wondering could we make an explicit
allow list of PrimitiveType enum to solve the issue, but didnt comment as
wondering if it was too much. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
