anoopj commented on code in PR #2922:
URL: https://github.com/apache/iceberg-rust/pull/2922#discussion_r3686841017
##########
crates/iceberg/src/spec/manifest_list/manifest_file.rs:
##########
@@ -195,8 +195,61 @@ impl ManifestFile {
entry.inherit_data(self);
}
+ self.assign_first_row_ids(&mut entries)?;
Review Comment:
This was a really good catch. I forgot that we are caching deserialized
files unlike Java. Thank you! Folded `first_row_id` into the cache key so the
same manifest path referenced with different offsets no longer shares an
entry. Added `test_get_manifest_keys_on_first_row_id` that loads the same path
twice with different offsets and asserts distinct inherited ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
