zakariya-s commented on code in PR #2932:
URL: https://github.com/apache/iceberg-rust/pull/2932#discussion_r3689769620
##########
crates/storage/opendal/src/gcs.rs:
##########
@@ -45,7 +48,9 @@ pub(crate) fn gcs_config_parse(mut m: HashMap<String,
String>) -> Result<GcsConf
cfg.endpoint = Some(endpoint);
}
- if m.remove(GCS_NO_AUTH).is_some() {
+ if let Some(no_auth) = m.remove(GCS_NO_AUTH)
+ && is_truthy(no_auth.to_lowercase().as_str())
+ {
Review Comment:
Drive-by fix since this looked pretty bad. AWS did this correctly, but GCS
would disable this even if `gcs.no-auth` was set to `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
