dannycjones commented on code in PR #2887:
URL: https://github.com/apache/iceberg-rust/pull/2887#discussion_r3691005927
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -110,6 +125,62 @@ impl ParquetWriterBuilder {
}
}
+fn parquet_compression(codec: &str, level: Option<i32>) -> Result<Compression>
{
+ let compression = match codec.to_lowercase().as_str() {
+ "uncompressed" | "none" => Compression::UNCOMPRESSED,
+ "snappy" => Compression::SNAPPY,
+ "lzo" => Compression::LZO,
+ "lz4" => Compression::LZ4,
+ "lz4_raw" => Compression::LZ4_RAW,
Review Comment:
It's not about the spec, since I don't think the writer properties are
considered part of the spec broadly.
I'm just a bit defensive of adding logic beyond what Java supports, since it
is broadening the feature surface we're responsible for. Especially with
Parquet, where some of the changes introduced are not forwards compatible.
I'm not strongly against adding these, happy to hear thoughts from others on
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
