dramaticlly commented on PR #17444: URL: https://github.com/apache/iceberg/pull/17444#issuecomment-5145184237
> LGTM > > this was originally marked for 2.0.0 deprecation (https://github.com/apache/iceberg/pull/9324/changes#diff-0ffc14da79d0ef5ce2e3e7da1f9241439061059ae5828c50c38ebf875281e2feR75) > > And changed to 1.12.0 in this PR: [dramaticlly@831b4ea#diff-0ffc14da79d0ef5ce2e3e7da1f9241439061059ae5828c50c38ebf875281e2feR84](https://github.com/dramaticlly/iceberg/commit/831b4ea108b9def6ae92258a7382aab096d87ed2#diff-0ffc14da79d0ef5ce2e3e7da1f9241439061059ae5828c50c38ebf875281e2feR84) It seems like there are other `2.0.0` -> `1.12.0` changes in that PR. Should we also look at the other changes to see if we should push them back to `2.0.0`? Thank @kevinjqliu. I think it's ok for now, we can have a separate PR if we need to delay more deprecations to 2.0 on case by case. This `NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED` in particular requires significant change and also shift the default behavior for externally provided parquet files, I think keep until 2.0 for major version change is more appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
